feat(advisor): Gate tools with read-only metadata#300
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
force-pushed
the
feat/advisor-readonly-mcp-tools
branch
from
41b562c to
52cdd3b
Compare
dcramer
force-pushed
the
feat/advisor-readonly-mcp-tools
branch
from
52cdd3b to
341c064
Compare
Expose advisor tools from explicit read-only annotations instead of a static allowlist. This keeps recursive, mutating, and MCP bridge tools out of the advisor runtime. Document MCP advisor access as future work and cover the production advisor tool set, including webFetch, with regression tests. Co-Authored-By: GPT-5 Codex <codex@openai.com>
dcramer
force-pushed
the
feat/advisor-readonly-mcp-tools
branch
from
341c064 to
acd3e1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advisor tool exposure now comes from tool annotations instead of the previous static allowlist. This lets the advisor receive host-marked read-only tools while keeping recursive, mutating, user-visible, and MCP bridge tools out of the advisor runtime.
Tool Metadata
Local read-only tools now declare MCP-style annotations, including webFetch, webSearch, file reads, system time, and read-only Slack surfaces. The advisor builds its tool set from readOnlyHint: true while vetoing destructiveHint: true.
MCP Follow-up
searchMcpTools and callMcpTool remain excluded from the advisor because nested advisor-run auth and resume behavior needs a separate contract before MCP tool calls are safe to expose.