Open
Conversation
Move Slack-backed conversation image and backfill details out of domain services so services depend on small injected ports instead of Slack infrastructure. Add an architecture guard and update the contract docs to keep the boundary enforceable. Co-Authored-By: GPT-5 Codex <codex@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce the chat architecture rule that domain services should not import Slack infrastructure directly. The service layer now depends on small injected ports for Slack-backed image hydration, while Slack and chat SDK details stay in the composition/runtime layer.
Architecture Boundary
Adds a dependency-cruiser rule preventing
src/chat/servicesfrom importingsrc/chat/slack, and records the rule in the local agent instructions and chat architecture spec.Service Cleanup
Moves chat SDK thread backfill handling into turn preparation and narrows the vision service dependency from Slack-specific helpers to
listThreadRepliesanddownloadFileports.