Skip to content

ci(release): Bump getsentry/craft to v3 - #728

Merged
BYK merged 1 commit into
mainfrom
ci/bump-craft-v3
Nov 3, 2026
Merged

BYK merged 1 commit into
mainfrom
ci/bump-craft-v3

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Changes getsentry/craft@v2 # v2 → @v3 in .github/workflows/release.yml.

Why: craft's v2 tag points at 2.35.1. Its "Check release blockers" step only asks GitHub to cancel the run and then exits 0, so the release keeps going and can open a getsentry/publish request while release-blocker issues are open. That's what happened in getsentry/symbolic run 41665569364. getsentry/craft#956 fixed it in 3.9.0, which v3 points at.

Compatibility: v2 → v3 is a major bump. I checked this repo against craft 3.0's breaking changes:

  • .craft.yml doesn't set changelog.includePaths or unownedPaths.
  • There's no nuget target.
  • It sets preReleaseCommand: "", so the new auto-bump failure can't trigger. craft 3.9.0 prepare 99.0.0 --dry-run --no-push succeeded.

Inputs, secrets, and permissions for the action and reusable workflows are the same in v2 and v3, or only gained optional additions.

There are no open release-blocker issues in this repo right now.

via @BYK.

--

View Session in Sentry

The v2 tag points at craft 2.35.1, whose release-blocker check only
requests run cancellation and keeps going, so a release can still open a
publish request while release-blocker issues are open. getsentry/craft#956
fixed this in 3.9.0, which v3 points at.

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Comment thread .github/workflows/release.yml Resolved
@BYK
BYK merged commit 96d2b97 into main Nov 3, 2026
23 checks passed
@BYK
BYK deleted the ci/bump-craft-v3 branch November 3, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant