Repository navigation
perf(apple): Reduce native parser lifetimes - #733
Merged
Merged
Conversation
Keep the Mach-O parser local to executable validation and pass it explicitly when checking the signature. This releases the native binary graph before resource validation and subsequent analysis.
Contributor
Size Analysis2 components analyzed iOS Builds
Android Builds
|
Contributor
📲 Install BuildsiOS
Android
|
Extract Python-owned symbols in a helper so native parser references leave scope before grouping and demangling. Materialize the results rather than yielding to avoid retaining the parser in a suspended generator.
jamieQ
force-pushed
the
perf/reduce-apple-parser-lifetimes
branch
from
November 9, 2026 15:26
0f86020 to
e62e94e
Compare
jamieQ
commented
Nov 9, 2026
| "binary_name": binary_info.name, | ||
| }, | ||
| ) | ||
| for arch_slice, slice_symbol_sizes in self._extract_dsym_symbols( |
Member
Author
There was a problem hiding this comment.
Note that there is a tradeoff here where we're eagerly producing the symbols for multiple architectures up front rather than on-demand as we were previously doing. It's possible that that could have worse memory use performance, but from checking how prod data looks I don't think it will matter today, and the change is definitely helpful for large single-arch binaries.
jamieQ
marked this pull request as ready for review
November 9, 2026 15:58
NicoHinderling
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to reduce peak memory use while processing large apps in common cases:
Both changes shorten the life of various LIEF objects that can consume substantial memory in larger apps.
Refs EME-1341