Skip to content

build(deps): Bump seaweedfs to 4.51 - #4595

Merged
geoffg-sentry merged 2 commits into
masterfrom
vuln-3216/seaweedfs-4.51
Oct 27, 2026
Merged

geoffg-sentry merged 2 commits into
masterfrom
vuln-3216/seaweedfs-4.51

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

The pinned chrislusf/seaweedfs:4.40_large_disk image is affected by both issues tracked in VULN-3216:

  • brotli-libs 1.2.0-r1 is vulnerable to CVE-2026-111497. Alpine 3.24 fixes it in 1.2.1-r0.
  • ca-certificates-bundle 20260611-r0 still trusts the compromised eMudhra emSign ECC Root CA - G3 root. Alpine fixes it in 20261020-r0.

4.51_large_disk (digest sha256:f44a1d38…) ships both fixed packages. I checked this by pulling the image and inspecting the apk db and the CA bundle.

  • docker-compose.yml: 4.40_large_disk@sha256:d07aa1da… → 4.51_large_disk@sha256:f44a1d38…, still pinned by digest
  • docker-compose.yml and install/migrate-seaweedfs-kek.sh: add -master.telemetry=false (see below)

That spans 11 upstream releases. Their release notes for 4.41–4.51 call out no breaking or migration changes, but 4.41 turned on anonymous cluster telemetry by default (seaweedfs/seaweedfs#10488). This PR turns it off on the weed mini service and on the temporary weed server master that the KEK migration starts. Both subcommands accept the flag in 4.51, and weed mini with it set still passes the master and S3 health checks.

Applies to fresh installs and upgrades. The integration tests, which exercise the S3 nodestore and profiles buckets, are the functional check.

via Geoff Goldsmith.

--

View Junior Session [Sentry]

Co-Authored-By: Geoff Goldsmith <geoff.goldsmith@sentry.io>
@linear-code

linear-code Bot commented Oct 27, 2026

Copy link
Copy Markdown

VULN-3216

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Coverage Results 📊

✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 9m 55s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 50%).
Project statement coverage is 95.58% (unchanged from base (dd77a9f) to head (75bc282)).

Coverage diff
@@            Coverage Diff             @@
##        master     #4595       +/-##
==========================================
  Coverage    95.58%    95.58%        —%
==========================================
  Files            5         5         —
  Tracked lines       339       339         —
  Branches         0         0         —
==========================================
  Hits           324       324         —
  Misses          15        15         —
  Partials         0         0         —

Generated by Coverage Action

@aminvakil aminvakil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor issue though:

seaweedfs/seaweedfs#10488 which is included since 4.41 enables telemetry by default, I do not know the circumstances and if this should be mentioned explicitly in release notes or not.
It can be disabled by adding -master.telemetry=false to seaweedfs command.

SeaweedFS reports anonymous cluster statistics by default since 4.41.
Pass -master.telemetry=false to the main service and to the temporary
master started during the KEK migration.

Refs VULN-3216

Co-Authored-By: Geoff Goldsmith <geoff.goldsmith@sentry.io>
@other-geoffrey

Copy link
Copy Markdown

A minor issue though:

seaweedfs/seaweedfs#10488 which is included since 4.41 enables telemetry by default, I do not know the circumstances and if this should be mentioned explicitly in release notes or not. It can be disabled by adding -master.telemetry=false to seaweedfs command.

Good catch, thank you. Disabling it for now to keep the old defaults

@geoffg-sentry
geoffg-sentry merged commit f435f7b into master Oct 27, 2026
23 checks passed
@geoffg-sentry
geoffg-sentry deleted the vuln-3216/seaweedfs-4.51 branch October 27, 2026 18:48
@aldy505

aldy505 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Honestly I'm not really confident with current SeaweedFS version, as there are so many bugs on it. I even filed an issue here: seaweedfs/seaweedfs#12119

There is also this issue: seaweedfs/seaweedfs#12145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants