Skip to content

chore: bump ClickHouse to 26.8 - #4614

Merged
aldy505 merged 2 commits into
masterfrom
aldy505/chore/bump-clickhouse-26.8
Nov 9, 2026
Merged

aldy505 merged 2 commits into
masterfrom
aldy505/chore/bump-clickhouse-26.8

Conversation

@aldy505

@aldy505 aldy505 commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

SaaS is running 26.8 now. See getsentry/snuba#8646

Closes #4611

SaaS is running 26.8 now. See getsentry/snuba#8646

Closes #4611

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d77d42f. Configure here.

Comment thread docker-compose.yml Resolved
@aminvakil

Copy link
Copy Markdown
Collaborator

<allow_nullable_key>1</allow_nullable_key> should be moved under <merge_tree> section.

https://clickhouse.com/docs/reference/settings/merge-tree-settings:

MergeTree settings can be set in the merge_tree section of the server config file, or specified for each MergeTree table individually in the SETTINGS clause of the CREATE TABLE statement.

https://clickhouse.com/docs/reference/settings/merge-tree-settings/allow#allow_nullable_key

ClickHouse/ClickHouse#100332 this is the PR which prevents and The server now refuses to start (and rejects SYSTEM RELOAD CONFIG) when the server config contains an unknown top-level element, instead of silently ignoring it.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Coverage Results 📊

✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 10m 45s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 50%).
Project statement coverage is 95.58% (unchanged from base (3f62007) to head (5ed89cd)).

Coverage diff
@@            Coverage Diff             @@
##        master     #4614       +/-##
==========================================
  Coverage    95.58%    95.58%        —%
==========================================
  Files            5         5         —
  Tracked lines       339       339         —
  Branches         0         0         —
==========================================
  Hits           324       324         —
  Misses          15        15         —
  Partials         0         0         —

Generated by Coverage Action

@aldy505
aldy505 merged commit a489128 into master Nov 9, 2026
27 of 29 checks passed
@aldy505
aldy505 deleted the aldy505/chore/bump-clickhouse-26.8 branch November 9, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Security] ClickHouse CVE-2026-116366 — Vulnerable Altinity build in Sentry Self-Hosted

3 participants