fix(inject): Skip non-base64 embedded sourcemaps#3243
Merged
loewenheim merged 3 commits intogetsentry:masterfrom Mar 26, 2026
Merged
fix(inject): Skip non-base64 embedded sourcemaps#3243loewenheim merged 3 commits intogetsentry:masterfrom
loewenheim merged 3 commits intogetsentry:masterfrom
Conversation
8 tasks
loewenheim
approved these changes
Mar 26, 2026
Contributor
loewenheim
left a comment
There was a problem hiding this comment.
Very nice, thank you for the fix!
Contributor
|
I took the liberty of adding a changelog entry. |
Contributor
Author
|
Thanks @loewenheim ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When you bundle tools like terser or babel into a single JS file (common in browser-based IDEs or bundler workers), their minified code contains template literals that build
//# sourceMappingURL=data:application/json;base64,...strings as output. After minification, these can land at the start of a line, anddiscover_sourcemaps_locationtreats them as real sourcemap directives.The problem is the "base64" payload is actually just more JS code, so decoding fails and
sourcemaps injectbails withInvalid embedded sourcemap, stopping the whole injection.This changes the
bail!to awarn!+continue, which matches how the injection flow already handles other non-fatal cases like missing sourcemaps, ambiguous paths, and unfound files. The file gets skipped and everything else processes normally.Includes a test with a minimal fixture that reproduces the issue.
Issues
#3244
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.