fix(build): Ungate ProgressBarMode::Response from managed feature#3247
Merged
runningcode merged 1 commit intomasterfrom Mar 26, 2026
Merged
fix(build): Ungate ProgressBarMode::Response from managed feature#3247runningcode merged 1 commit intomasterfrom
runningcode merged 1 commit intomasterfrom
Conversation
The `Response` variant was gated behind `#[cfg(not(feature = "managed"))]` because its only consumer (`download_with_progress`) was also managed-gated. The new `download_installable_build` method (used by `build download`) references this variant without a managed gate, breaking the Docker build which compiles with `--features managed`. The progress bar has nothing to do with managed mode, so remove the feature gate from the variant and simplify the `response()` method. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Ungate ProgressBarMode::Response from managed feature ([#3247](https://github.com/getsentry/sentry-cli/pull/3247))If none of the above apply, you can opt out of this check by adding |
loewenheim
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProgressBarMode::Responsewas gated behind#[cfg(not(feature = "managed"))]because its only consumer (download_with_progress) was also managed-gateddownload_installable_buildmethod (used bybuild download) references this variant without a managed gate, breaking the Docker build (--features managed)response()method#skip-changelog
🤖 Generated with Claude Code