Skip to content

chore: Added cron job to check for upstream changes to vendored in code#5000

Merged
Flash0ver merged 8 commits intomainfrom
watch-upstream
Mar 17, 2026
Merged

chore: Added cron job to check for upstream changes to vendored in code#5000
Flash0ver merged 8 commits intomainfrom
watch-upstream

Conversation

@jamescrosswell
Copy link
Copy Markdown
Collaborator

@jamescrosswell jamescrosswell commented Mar 11, 2026

Resolves #4995

Notes for testing

All the github workflow does is run the script on a cron schedule, passing it some parameters. The script can be tested locally by running:

export GH_TOKEN="$(gh auth token)"
export GH_REPO="getsentry/sentry-dotnet"
./scripts/watch-upstream.sh dotnet/android tools/assembly-store-reader-mk2 src/Sentry.Android.AssemblyReader/

... that assumes you're logged into the github cli locally.

Important

The script will create one (and only one) issue for every upstream change it detects affecting the configured source tree. For testing, it created this issue:

#skip-changelog

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 11, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.06%. Comparing base (ec307a7) to head (b8a07bb).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5000      +/-   ##
==========================================
+ Coverage   73.90%   74.06%   +0.16%     
==========================================
  Files         497      497              
  Lines       17957    17969      +12     
  Branches     3516     3517       +1     
==========================================
+ Hits        13271    13309      +38     
+ Misses       3825     3800      -25     
+ Partials      861      860       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell jamescrosswell added .NET Pull requests that update .net code Repository Maintenance labels Mar 11, 2026
@jamescrosswell jamescrosswell marked this pull request as ready for review March 11, 2026 21:24
Comment thread scripts/watch-upstream.sh
Comment thread .github/workflows/watch-upstream.yml
Comment thread .github/workflows/watch-upstream.yml Outdated
Comment thread scripts/watch-upstream.sh Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Backslash path separators inconsistent with all existing entries
    • Replaced the three backslash-based File Path entries in Sentry.slnx and .generated.NoMobile.slnx with forward slashes to match existing solution path conventions and cross-platform resolution behavior.

Create PR

Or push these changes by commenting:

@cursor push acacc38d1e
Preview (acacc38d1e)
diff --git a/.generated.NoMobile.slnx b/.generated.NoMobile.slnx
--- a/.generated.NoMobile.slnx
+++ b/.generated.NoMobile.slnx
@@ -33,7 +33,7 @@
     <File Path=".github/workflows/update-deps.yml" />
     <File Path=".github/workflows/vulnerabilities.yml" />
     <File Path=".github/workflows/playwright-blazor-wasm.yml" />
-    <File Path=".github\workflows\watch-upstream.yml" />
+    <File Path=".github/workflows/watch-upstream.yml" />
   </Folder>
   <Folder Name="/benchmarks/">
     <Project Path="benchmarks/Sentry.Benchmarks/Sentry.Benchmarks.csproj" />

diff --git a/Sentry.slnx b/Sentry.slnx
--- a/Sentry.slnx
+++ b/Sentry.slnx
@@ -33,7 +33,7 @@
     <File Path=".github/workflows/update-deps.yml" />
     <File Path=".github/workflows/vulnerabilities.yml" />
     <File Path=".github/workflows/playwright-blazor-wasm.yml" />
-    <File Path=".github\workflows\watch-upstream.yml" />
+    <File Path=".github/workflows/watch-upstream.yml" />
   </Folder>
   <Folder Name="/benchmarks/">
     <Project Path="benchmarks/Sentry.Benchmarks/Sentry.Benchmarks.csproj" />
@@ -121,7 +121,7 @@
     <File Path="scripts/update-cli.ps1" />
     <File Path="scripts/update-java.ps1" />
     <File Path="scripts/update-project-xml.ps1" />
-    <File Path="scripts\watch-upstream.sh" />
+    <File Path="scripts/watch-upstream.sh" />
   </Folder>
   <Folder Name="/src/">
     <File Path="src/Directory.Build.props" />

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Comment thread Sentry.slnx Outdated
Comment thread scripts/watch-upstream.sh
Comment thread scripts/watch-upstream.sh Outdated
Comment thread scripts/watch-upstream.sh Outdated
@Flash0ver Flash0ver merged commit fd57a21 into main Mar 17, 2026
31 checks passed
@Flash0ver Flash0ver deleted the watch-upstream branch March 17, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Pull requests that update .net code Repository Maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create watch on upstream repositories that we've vendored in

2 participants