ref(cache): [Cache Tracing 20] Remove _KEY suffix from cache SpanDataConvention constants#5209
Draft
adinauer wants to merge 1 commit intofix/cache-tracing-jcache-bulk-descriptionfrom
Draft
Conversation
Rename CACHE_HIT_KEY, CACHE_KEY_KEY, and CACHE_OPERATION_KEY to CACHE_HIT, CACHE_KEY, and CACHE_OPERATION to match the newer naming convention used by CACHE_WRITE, THREAD_ID, FRAMES_TOTAL, etc. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
This was referenced Mar 18, 2026
Draft
fix(spring): [Cache Tracing 14] Fix cache hit detection for typed get and fix jcache docs link
#5203
Draft
Draft
Sentry Build Distribution
|
Member
Author
|
@sentry review |
Member
Author
|
cursor review |
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Cache Tracing)
📜 Description
Renames
CACHE_HIT_KEY,CACHE_KEY_KEY, andCACHE_OPERATION_KEYtoCACHE_HIT,CACHE_KEY, andCACHE_OPERATIONinSpanDataConventionto match the newer naming convention used byCACHE_WRITE,THREAD_ID,FRAMES_TOTAL, etc.💡 Motivation and Context
The older constants in
SpanDataConventionuse a_KEYsuffix (e.g.DB_SYSTEM_KEY), but newer additions dropped this pattern. The three cache constants added in earlier stack PRs followed the old convention; this aligns them with the current style alongsideCACHE_WRITEwhich was already correct.💚 How did you test it?
Rename-only change verified by successful
apiDumpandspotlessApply. No logic change.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.
#skip-changelog