Skip to content

fix(spans): Don't drop segments when title generation fails #129084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enochtangg merged 2 commits into from
Nov 2, 2026
Merged

fix(spans): Don't drop segments when title generation fails #129084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfd440d
fix(spans): Don't drop segments when title generation fails
enochtangg Oct 28, 2026
8d603a9
comment
enochtangg Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sentry/spans/consumers/process_segments/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,10 @@ def _process_segment(
return []

# Always attempt title generation, even when enrichment is skipped below.
spawn_conversation_title_generation(unprocessed_spans, project)
try:
spawn_conversation_title_generation(unprocessed_spans, project)
except Exception:
logger.exception("spans.process_segments.title_generation.error")

if skip_enrichment:
return [make_compatible(span) for span in unprocessed_spans]
Expand Down
12 changes: 12 additions & 0 deletions tests/sentry/spans/consumers/process_segments/test_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,18 @@ def test_enrich_spans_no_segment(self) -> None:
assert span["op"]
assert span["hash"]

@mock.patch.object(message_module, "spawn_conversation_title_generation")
def test_title_generation_failure_keeps_segment(self, mock_spawn: mock.MagicMock) -> None:
mock_spawn.side_effect = UnicodeEncodeError("utf-8", "hi", 0, 1, "surrogates not allowed")
spans = self.generate_basic_spans()

with mock.patch.object(message_module.logger, "exception") as mock_log:
processed_spans = process_segment(spans)

assert len(processed_spans) == len(spans)
mock_spawn.assert_called_once()
mock_log.assert_any_call("spans.process_segments.title_generation.error")

def test_build_shim_event_data_supports_legacy_profile_id(self) -> None:
segment_span = build_mock_span(project_id=self.project.id, is_segment=True)
segment_span["hash"] = "hashed-segment"
Expand Down
Loading