[axchadxs]

scan_skill.py aborted with a RuntimeError traceback when a skill contained a symlink loop (for example a file that links to itself) on Python 3.12 and earlier, so no report was produced and the skill was not scanned at all. Python 3.13 no longer raises here, so the same input already scanned fine there.

check_structural_attacks now catches the loop and reports the link as a "Symlink Detected" finding with medium severity, which matches what 3.13 already reports for the same input. Output for ordinary, external, and dangling symlinks is unchanged.

To reproduce on Python 3.12:

mkdir -p demo-skill/references
printf -- '---\nname: demo-skill\ndescription: Demo skill for scanner tests.\n---\n\n# Demo\n' > demo-skill/SKILL.md
ln -s self.md demo-skill/references/self.md
uv run skills/skill-scanner/scripts/scan_skill.py demo-skill

Before: exit 1 with "RuntimeError: Symlink loop". After: exit 0 and one medium "Symlink Detected" finding. I also checked a two-file loop (a.md and b.md pointing at each other) and a directory loop on Python 3.9, 3.11, 3.12 and 3.13, and confirmed the JSON output for internal, external, and dangling symlinks is byte-identical to before.

I chose medium rather than critical because a loop never resolves to a file, so it can't reach anything outside the skill. Happy to change it if you would rather treat unresolvable links as critical.

Fixes #188

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.