Repository navigation
Conversation
…ferrer's limit The throttle threshold was always default_concurrent_request_per_referrer // requests_throttle_divider, even for a referrer with referrer_concurrent_override. It now uses that referrer's effective limit. Referrers without an override are unchanged.
dezzeddi
marked this pull request as ready for review
November 3, 2026 23:02
ElioDiNino
approved these changes
Nov 9, 2026
ElioDiNino
left a comment
ElioDiNino
left a comment
Member
There was a problem hiding this comment.
Looks good but consider adding a test for the current behavior (where referrer_concurrent_override is not set), to ensure the default gets used
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
ReferrerGuardRailPolicy's throttle point was always calculated from the default limit (default_concurrent_request_per_referrer, 100 // 1.5 = 66) and never tookreferrer_concurrent_overrideinto account. It now uses the referrer's own limit //requests_throttle_divider.referrer_concurrent_overrideisn't set in any region today, so nothing changes yet.