Repository navigation
feat(admin): Fold shared-node storages and skip host words in node search - #8680
Merged
Merged
Conversation
…arch In production, many storages use the same nodes, which made the storage lists long and repetitive. Every eap_items storage (downsampled, co-occurring attributes, ...) now shows as eap_items, or eap_items_ro for the read-only ones, and the outcomes storage set shows as outcomes_raw. That applies to the storage line under each node and to the storage pickers. The selected storage is always kept in the picker, and the storage sent with a query is still chosen from all of the node's storages. Hosts like snuba-events-analytics-platform-arm-1-1 and ...-mz-1-1 didn't match eap-1-1. A typed separator can now skip one whole host word that starts with a letter, counted as a boundary miss so exact hosts rank first. Number words (shards, replicas, ports) are never skipped, so their positions still count. Co-Authored-By: Claude <noreply@anthropic.com>
onewland
marked this pull request as ready for review
November 6, 2026 15:22
The eap_items and outcomes folding hard-coded which storages share nodes. The storage configuration already says this: a storage set belongs to exactly one cluster (snuba/clusters/cluster.py asserts it), so its storages always share their nodes. /clickhouse_nodes now reports each storage's set, and storage lists show the shortest name in each set. That gives the same result for eap_items, eap_items_ro and outcomes_raw, also folds the metrics, functions and replays sets, and picks up new storages without any change here. Co-Authored-By: Claude <noreply@anthropic.com>
In distributed mode /clickhouse_nodes looks up cluster topology in ClickHouse, which the test harness blocks unless the test is marked. Co-Authored-By: Claude <noreply@anthropic.com>
…etsentry/snuba into feat/admin-node-search-eap-refinements
ElioDiNino
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two refinements to the System Queries node search from #8609, based on how production hostnames and storages actually look.
Folding storages that share nodes. In production, many storages use the same nodes, so the storage line under each node and the storage pickers repeat the same cluster under many names. Storage lists now show one storage per storage set. A storage set belongs to exactly one cluster (
snuba/clusters/cluster.pyasserts it), so its storages always share their nodes./clickhouse_nodesnow reports each storage'sstorage_set, and the shortest name in each set stands in for the rest:events_analytics_platformeap_items(foreap_items_2, thedownsample_*ones,eap_item_co_occurring_attrs, …)events_analytics_platform_roeap_items_ro(for the_roversions)outcomesoutcomes_raw(foroutcomes_hourly,outcomes_daily,outcomes_cross_org_hourly,llm_proxy_cost_raw)metricsmetrics_raw(formetrics_counters,metrics_distributions,metrics_sets,org_metrics_counters)functionsfunctionsreplaysreplaysFolding only changes what's listed:
eap_items_2but noteap_itemsshowseap_items_2.eap_items_downsample_8still work.The first commit hard-coded this for eap_items and outcomes by name. The second replaces that with the storage set, which the config already maintains, so new storages fold without any change here. I considered an admin-only alias or hide flag in the storage YAML. It would mostly repeat what
set_keyalready says, and it needs a schema change and flags on about 20 storages. If a real exception comes up, a smallhiddenoverride would be enough.Skipping a host word. Hosts like
snuba-events-analytics-platform-arm-1-1and…-mz-1-1matchedeap-arm-1-1but noteap-1-1. A typed separator can now skip one whole host word that starts with a letter:…-1-1hosts still rank first.eap-1would match every replica-1 host.NODE_SEARCH.mddocuments both rules, with new rows in its examples table.🤖 Generated with Claude Code