Repository navigation
ref(consumers): Remove the unused dlq-consumer (EAP-944) - #8690
Draft
ElioDiNino wants to merge 1 commit into
Draft
ElioDiNino wants to merge 1 commit into
ElioDiNino wants to merge 1 commit into
Conversation
The dlq-consumer replayed a storage's DLQ when Snuba admin wrote an instruction to the dlq Redis cluster. That admin tool was removed in #8200, so nothing can start a replay, and Datadog has no snuba.dlq_consumer metrics in its 15-month retention window. Remove the CLI command, the instruction helpers, the DLQ builder methods, the max_messages_to_process option only it used, the dlq Redis client and its deploy container.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
dlq-consumerCLI command and the code that only it used. It replayed a storage's DLQ when Snuba admin wrote an instruction to thedlqRedis cluster. That admin tool was removed in #8200, so nothing can start a replay anymore, and Datadog shows no usage in its retention window.snuba/cli/dlq_consumer.pyandsnuba/consumers/dlq.py(instructions, Redis helpers,ExitAfterNMessages) and their tests.ConsumerBuilder: dropbuild_dlq_strategy_factoryandbuild_dlq_consumer.KafkaConsumerStrategyFactory: dropmax_messages_to_process, which only the DLQ consumer passed.dlqRedis cluster (RedisClientKey.DLQ,REDIS_CLUSTERS["dlq"]).deploy-py.sh: stop targeting thedlq-consumercontainer.The
eap-items-dlq-replay-consumerand the regular DLQ policy on consumers are unaffected.Ticket: EAP-944