Repository navigation
fix(config): Reject pending and delay limits below the insert batch length - #854
Merged
Merged
Conversation
…ength The activation writer only stores a batch when pending + batch.len() is within the limit, and it never splits a batch. If max_pending_count (or a topic's max_pending_activations, or max_delay_count) is below insert_batch_max_length, a full batch can never be written, even with an empty store. The writer retries it forever and the consumer stops. Low traffic hides this because batches flush on the timer before they fill. Check this at startup in normalize_and_validate. The global pending limit is only checked when at least one consumed topic has no limit of its own. Produce-only topics are skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
enochtangg
marked this pull request as ready for review
November 10, 2026 15:13
evanh
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taskbroker now refuses to start if
max_pending_count, a topic'smax_pending_activations, ormax_delay_countis belowinsert_batch_max_length. With those values, a full batch can never be written and the consumer stops for good.Why
The activation writer only stores a batch when
pending + batch.len()is within the limit, and it never splits a batch. If the limit is below the batch length, a full batch fails the check even with an empty store. The writer retries the same batch forever and that topic's consumer stops until someone fixes the config and redeploys.