Skip to content

feat(taskworker): Add opt-in wait for child exit during recycling #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamieQ wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(taskworker): Add opt-in wait for child exit during recycling #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
077036c
feat(taskworker): Add opt-in wait for child exit during recycling
jamieQ Nov 9, 2026
9ed5292
feat(taskworker): Report oldest exiting child age
jamieQ Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions clients/python/src/taskbroker_client/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ def scheduler() -> None:
default=0,
type=int,
)
@click.option(
"--wait-for-child-exit/--no-wait-for-child-exit",
help="Count retiring children toward concurrency until they exit. May reduce recycling throughput.",
default=False,
)
@click.option(
"--child-tasks-queue-maxsize",
help="Maximum number of pending tasks buffered for child processes.",
Expand Down Expand Up @@ -174,6 +179,7 @@ def pull(
namespace: str | None,
concurrency: int,
min_concurrency: int,
wait_for_child_exit: bool,
child_tasks_queue_maxsize: int,
result_queue_maxsize: int,
rebalance_after: int,
Expand All @@ -197,6 +203,7 @@ def pull(
namespace=namespace,
concurrency=concurrency,
min_concurrency=min_concurrency,
wait_for_child_exit=wait_for_child_exit,
child_tasks_queue_maxsize=child_tasks_queue_maxsize,
result_queue_maxsize=result_queue_maxsize,
rebalance_after=rebalance_after,
Expand Down Expand Up @@ -245,6 +252,11 @@ def pull(
default=0,
type=int,
)
@click.option(
"--wait-for-child-exit/--no-wait-for-child-exit",
help="Count retiring children toward concurrency until they exit. May reduce recycling throughput.",
default=False,
)
@click.option(
"--child-tasks-queue-maxsize",
help="Maximum number of pending tasks buffered for child processes.",
Expand Down Expand Up @@ -343,6 +355,7 @@ def push(
namespace: str | None,
concurrency: int,
min_concurrency: int,
wait_for_child_exit: bool,
child_tasks_queue_maxsize: int,
result_queue_maxsize: int,
rebalance_after: int,
Expand Down Expand Up @@ -372,6 +385,7 @@ def push(
namespace=namespace,
concurrency=concurrency,
min_concurrency=min_concurrency,
wait_for_child_exit=wait_for_child_exit,
child_tasks_queue_maxsize=child_tasks_queue_maxsize,
result_queue_maxsize=result_queue_maxsize,
rebalance_after=rebalance_after,
Expand Down
Loading
Loading