Skip to content

fix(gocd): Remove indented comment that breaks config-repo parsing - #858

Merged
lvthanh03 merged 1 commit into
mainfrom
tony/fix-migrations-script
Nov 10, 2026
Merged

lvthanh03 merged 1 commit into
mainfrom
tony/fix-migrations-script

Conversation

@lvthanh03

Copy link
Copy Markdown
Member

GoCD reads # as the start of a #{param} unless it is followed by { or another #.
The taskbroker config repo failed to parse, and GoCD kept running the pre-#856 migration script, which still produced job names over the 63-char label limit.

@lvthanh03
lvthanh03 requested a review from a team as a code owner November 10, 2026 19:27
@lvthanh03
lvthanh03 enabled auto-merge (squash) November 10, 2026 19:28
@lvthanh03
lvthanh03 merged commit 41eee08 into main Nov 10, 2026
27 checks passed
@lvthanh03
lvthanh03 deleted the tony/fix-migrations-script branch November 10, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants