Skip to content

fix(mcp): Preserve time-series values and provenance - #2016

Open
nsdeschenes wants to merge 4 commits into
feat/exp-1408-time-series-contractfrom
feat/exp-1408-time-series-results
Open

nsdeschenes wants to merge 4 commits into
feat/exp-1408-time-series-contractfrom
feat/exp-1408-time-series-results

Conversation

@nsdeschenes

@nsdeschenes nsdeschenes commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Build the result projection for explicit and translated transformed time series in EXP-1408. Preserve nulls, units, comparisons, and transformation flags; omit transformed totals and label derived maxima. Reject unsupported series shapes and responses that do not confirm transformation execution.

@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-local Ready Ready Preview Nov 9, 2026 12:03pm UTC

Request Review

@linear-code

linear-code Bot commented Nov 5, 2026

Copy link
Copy Markdown

EXP-1408

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@nsdeschenes
nsdeschenes added this pull request to stack #2049 November 6, 2026 15:19
@nsdeschenes nsdeschenes changed the title fix(mcp): preserve time-series values and provenance fix(mcp): Preserve time-series values and provenance Nov 6, 2026

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@nsdeschenes
nsdeschenes marked this pull request as ready for review November 6, 2026 17:10
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 6, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8341cb4. Configure here.

nsdeschenes and others added 3 commits November 9, 2026 07:44
Keep missing buckets distinct from observed zero and retain comparisons,
units, and transformation metadata in result output. Reject response shapes
that cannot be represented faithfully.

Refs EXP-1408

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Include final OUTSIDE_RETENTION buckets when finding peaks while excluding
buckets still receiving data. Compare ISO datetime values by parsed time
and retain the original response value in the structured summary.

Add regression coverage for raw and transformed retention maxima and date
values mixed with empty buckets and an incomplete trailing bucket.

Refs EXP-1408

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Merge the narrowed shared schema and remove sampling, scan, ingestion, and
extra executed-range projection. Restore the existing Markdown formatter
and its tests because transformed searches use structured output.

Keep required values, units, comparisons, transformation flags, shape
validation, and correct raw and derived summaries.

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Merge the updated contract layer and exclude zero-filled date buckets from
peak and derived maximum calculations. Preserve legitimate numeric zeros.

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>

This branch was successfully deployed

2 active deployments
Preview — 64d45fc8 Deployed Nov 9, 2026 by vercel[bot]
Actions — 64d45fc8 Deployed Nov 9, 2026 by nsdeschenes via eval #1741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant