Repository navigation
fix(cli): Accept null stats on later agent conversation pages - #2108
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
The conversation details endpoint returns stats on the first page and stats: null on every page after it. The response schema only allowed a missing stats field, so agent-conversation view failed with "Unexpected response format" on any conversation with more than one page of spans. Co-Authored-By: Ognjen Bostjancic <ognjen.bostjancic@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry agent-conversation viewfails on any conversation with more than one page of spans (1,000+):The details endpoint returns
statson the first page andstats: nullon every later page, as its API docs describe.AgentConversationDetailsSchematypedstatsasoptional, which allows the field to be missing but notnull, so validation failed on page 2.This changes the field to
nullish.getConversationSpansalready reads stats from the first page only. The new test covers a two-page response where page 2 sendsstats: null. Without the fix it fails with the same error.Fixes AGT-3286
via Ogi.
--
View Session [Sentry]