Repository navigation
fix(cli): Redact sensitive flag values in unknown command telemetry - #2115
Merged
Merged
Conversation
reportUnknownCommand() derived pathSegments, unknown_token, org/project, and arg_count from raw argv before redacting. A sensitive flag value (e.g. --token SECRET) survived as a path segment and appeared verbatim in unknown_token. The --flag=VALUE form also leaked through the argv.at(-1) fallback. Move redactArgv() to the top of the function and use safeArgv for every derived field. Refs VDY-366 Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
BYK
approved these changes
Nov 9, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reportUnknownCommand()buildspathSegments,unknown_token, the org and project guess, andarg_countfrom raw argv before redacting. That means a sensitive flag value (e.g.--token) survives in two ways: as a path segment that becomesunknown_tokenfor the--flag VALUEform, and as theargv.at(-1)fallback for the--flag=VALUEform.Move
redactArgv()to the top of the function and usesafeArgvfor every derived field.Refs VDY-366
Verification
sentry alert --token SECRETandsentry alert --token=SECRETboth no longer appear inunknown_commandtelemetry contextunknown_token), passes with itpnpm run typecheck && pnpm run lintclean