Repository navigation
fix(uptime): Explain seat errors when enabling a monitor - #2120
Merged
Merged
Conversation
When an organization has no seat or budget, update_uptime_monitor returned the raw API body and agents kept retrying. Tell them the monitor stays disabled and what has to change first.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling an uptime monitor fails with a field error when the organization has no seat or pay-as-you-go budget.
update_uptime_monitorpassed that error through as a raw JSON body, and these failures are a large share of the tool's 400s. The tool now returns the server's reason, says that the monitor is still disabled, and tells the agent not to retry until the budget changes or another monitor is disabled.Other validation errors are unchanged. The check reads
detailbecause@sentry/apidrops the parsed body for errors that have nodetailfield.