Skip to content

ci(release): Bump craft to 3.9.0 and update config - #82

Open
sentry-junior[bot] wants to merge 2 commits into
mainfrom
ci/bump-craft-3.9.0
Open

sentry-junior[bot] wants to merge 2 commits into
mainfrom
ci/bump-craft-3.9.0

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

This bumps both craft pins to 3.9.0 (2e29b081). The getsentry/craft action in py-release.yaml moves from 2.19.0 (c6e2f049), and the changelog-preview.yml reusable workflow moves from 2.25.0 (f4889d04).

Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so later steps kept going and could still open a getsentry/publish issue while a release-blocker issue was open (example run in getsentry/symbolic). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and also fails if the blocker lookup errors. Same change as getsentry/symbolic#1134.

Compatibility with craft 3.x:

  • Action inputs only gained new optional ones between 2.x and 3.9.0, so the existing with: inputs need no changes. That includes path: py. The reusable changelog-preview workflow still accepts working-directory.
  • None of the 3.0 breaking changes apply. py/.craft.yml doesn't set changelog.includePaths or unownedPaths, and it defines preReleaseCommand. There's no nuget target, so the 3.0 nuget change doesn't apply.
  • craft 3.9.0 prepare 99.0.0 --dry-run --no-push --no-changelog from py/ against current main ran ../scripts/bump-version-py.sh and finished without errors. I ran --no-changelog because the sandbox's network proxy stalls on the large GitHub GraphQL response craft uses to build the changelog. That's a limitation of my environment, not a config problem, so the changelog step itself wasn't exercised.

Unrelated to this PR: in that dry run, bump-version-py.sh also rewrote pytest's minversion = "0.0.11" in pyproject.toml, because its version = "..." pattern matches that line too. You may want to look at it separately.

There are no open release-blocker issues right now. Once this lands, an open one stops the release until it's closed or force is set.

Config changes

py/.craft.yml: minVersion 0.34.1 -> 3.9.0, plus versioning.policy: manual, which keeps the old default below 2.14.0. changelog.policy and preReleaseCommand were already set, so release behavior stays the same.

Dry run before and after (from py/): the same file gets bumped (py/pyproject.toml), and there are no errors.

via @BYK.

--

View Session in Sentry

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior
sentry-junior Bot requested a review from a team as a code owner November 3, 2026 21:14

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e71d31c. Configure here.

Comment thread .github/workflows/py-release.yaml Resolved
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior sentry-junior Bot changed the title ci(release): Bump getsentry/craft to 3.9.0 ci(release): Bump craft to 3.9.0 and update config Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant