Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #82
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e71d31c. Configure here.
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This bumps both craft pins to 3.9.0 (
2e29b081). Thegetsentry/craftaction inpy-release.yamlmoves from 2.19.0 (c6e2f049), and thechangelog-preview.ymlreusable workflow moves from 2.25.0 (f4889d04).Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so later steps kept going and could still open a getsentry/publish issue while a
release-blockerissue was open (example run in getsentry/symbolic). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and also fails if the blocker lookup errors. Same change as getsentry/symbolic#1134.Compatibility with craft 3.x:
with:inputs need no changes. That includespath: py. The reusable changelog-preview workflow still acceptsworking-directory.py/.craft.ymldoesn't setchangelog.includePathsorunownedPaths, and it definespreReleaseCommand. There's no nuget target, so the 3.0 nuget change doesn't apply.prepare 99.0.0 --dry-run --no-push --no-changelogfrompy/against currentmainran../scripts/bump-version-py.shand finished without errors. I ran--no-changelogbecause the sandbox's network proxy stalls on the large GitHub GraphQL response craft uses to build the changelog. That's a limitation of my environment, not a config problem, so the changelog step itself wasn't exercised.Unrelated to this PR: in that dry run,
bump-version-py.shalso rewrote pytest'sminversion = "0.0.11"inpyproject.toml, because itsversion = "..."pattern matches that line too. You may want to look at it separately.There are no open
release-blockerissues right now. Once this lands, an open one stops the release until it's closed orforceis set.Config changes
py/.craft.yml:minVersion0.34.1->3.9.0, plusversioning.policy: manual, which keeps the old default below 2.14.0.changelog.policyandpreReleaseCommandwere already set, so release behavior stays the same.Dry run before and after (from
py/): the same file gets bumped (py/pyproject.toml), and there are no errors.via @BYK.
--
View Session in Sentry