Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #766
Merged
Merged
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
sentry-junior
Bot
changed the title
BYK
approved these changes
Nov 4, 2026
BYK
enabled auto-merge (squash)
November 4, 2026 00:09
mjq
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned
getsentry/craftaction from 3.4.1 (90e8e203) to 3.9.0 (2e29b081).Craft's "Check release blockers" step used to call the async run-cancel API and then exit 0, so the job kept going and could still open a getsentry/publish issue while
release-blockerissues were open (example in getsentry/symbolic). getsentry/craft#956 fixed that, and the fix shipped in craft 3.9.0. This is the same change as getsentry/symbolic#1134.This repo is already on craft 3.x.
minVersionis 2.18.0, so it usesscripts/bump-version.sh. There's no top-levelchangelog.includePaths/unownedPathsand no nuget target. I ran craft 3.9.0'scraft prepare 99.0.0 --dry-run --no-input --no-pushon the default branch before this change. It passed.changelog-preview.ymluses the floating@v3tag, so I left it alone.There are no open
release-blockerissues here, so nothing stops the next release. From now on, any openrelease-blockerissue will stop the release.Config changes:
minVersion2.18.0 → 3.9.0. This addspreReleaseCommand: bash scripts/bump-version.shbecause craft only runs that script by default below 2.21.0.versioning.policy: calverwas already explicit. craft 3.9.0'sprepare 99.0.0 --dry-rungave the same result before and after this change.via @BYK.
--
View Session in Sentry