fix: degrade mixed CrUX failures to no-data#31
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Conversation
When one requested device errors but another request completes without\nusable CrUX metrics, the workflow should take the existing no-data\npath instead of raising a tool exception. Keep hard failures for cases\nwhere every requested device fetch fails.\n\nFixes WEBVITALS-2Q\nCo-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Sergiy Dybskiy <s@serg.tech>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression in WEBVITALS-2Q.
getRealWorldPerformancetreated any upstream CrUX fetch error as fatal when no usable metrics were returned, even if another requested device completed successfully but legitimately had no CrUX field data.3dad06a481817bc715ba83934de828125c64fb2cstill shipped the strict fatal gate, so transient Google CrUX 500s reopened the issue whenever the other device response produced no usable metrics. I could not identify a resolving commit/PR from the Sentry MCP activity payload.error + no-dataoutcomes now degrade tohasData: false, which preserves the existing empty-state UI/workflow path instead of surfacing a workflow error.Type of Change
Sentry Context
3dad06a481817bc715ba83934de828125c64fb2cVerification
pnpm check-typespasses.pnpm lintstill fails because of pre-existing repo-wide Biome violations unrelated to this change.POST /api/chatforhttps://dbavc-ca.vercel.app; the route now returns200 OKwith a workflow run ID instead of bubbling the CrUX failure.No CrUX data availableempty state rather than crashing.Checklist
pnpm check-types)pnpm lint)Test plan