fix: degrade invalid CrUX URLs to no-data#34
Draft
cursor[bot] wants to merge 2 commits intomainfrom
Draft
Conversation
Treat CrUX 400 responses for unsupported or uncovered URLs as\nrecoverable so the analysis workflow returns the existing empty-state\noutput instead of capturing an application exception.\n\nKeep non-recoverable CrUX failures blocking so infrastructure and auth\nproblems still surface for investigation.\n\nFixes WEBVITALS-2S\nCo-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Sergiy Dybskiy <s@serg.tech>
Align the CrUX 400 fallback change with the repository formatter so\nreviewers can isolate the behavior change from unrelated lint noise.\n\nRefs WEBVITALS-2S\nCo-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Sergiy Dybskiy <s@serg.tech>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression in WEBVITALS-2S.
ai/tools/real-world-performance.tstreated CrUX HTTP 400 responses as hard workflow failures. Google returns 400 for URLs with query params and for origins/pages without CrUX coverage, but the product already has ahasData: falseempty-state for that condition.e93dc0f, and the deployed release onmain(3dad06a481817bc715ba83934de828125c64fb2c) still contained that behavior when the issue resurfaced on new traffic.Sentry Context
3dad06a481817bc715ba83934de828125c64fb2cType of Change
Checklist
pnpm check-types)pnpm lint)Verification
Focused verification only:
pnpm exec vitest run ".tmp-crux-400-regression.test.ts" --config vitest.config.tspnpm check-typespnpm exec biome check "ai/tools/real-world-performance.ts"Limitations:
pnpm lintstill fails on pre-existing repo-wide issues unrelated to this change (for exampleai/tools/tech-detection.ts,app/api/chat/[id]/stream/route.ts, andapp/globals.css).