Fix versionInRange for multi-interval OSV ranges#18
Merged
Conversation
When an OSV range has multiple introduced/fixed intervals, a later introduced event would overwrite inRange to false even when the version was already matched by an earlier interval. Now introduced events can only set inRange to true, never reset it to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`versionInRange` returned false for versions that fell within the first interval of a multi-interval range. The `introduced` event unconditionally assigned to `inRange`, so a later interval whose `introduced` version was above the target would reset it to false.
For example, with events `[introduced:0, fixed:1.0, introduced:2.0, fixed:3.0]`, version `0.5` would be correctly matched by the first interval, then incorrectly reset to false by `introduced:2.0`.
The fix: `introduced` events can only set `inRange` to true, never to false.