Verify checksum and limit decompressed size in grypedb Download#19
Merged
Conversation
The listing provides a sha256 checksum for each database archive but it was not verified after download. Also wraps the gzip reader in io.LimitReader (2 GB) to bound decompressed output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grype database listing includes a `sha256` checksum for each archive but `Download` was not verifying it. Also caps decompressed output at 2 GB via `io.LimitReader` to prevent unbounded disk writes from a tampered archive.
Extracts `downloadFrom` to accept the listing URL, making the function testable without hitting the real CDN.