codex-agent-hooks#13651
Closed
robertmonka wants to merge 3 commits intogitbutlerapp:masterfrom
Closed
Conversation
fee7ce7 to
02f2954
Compare
02f2954 to
e73cec1
Compare
Collaborator
|
I'm very sorry, but I have to close all of your PRs on the basis of them being fully automated coming from a profile that doesn't show much related history. Thanks a lot for your understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧢 Changes
but-codexcrate with native Codex hook handling.but codex pre-toolbut codex post-toolbut codex stopSource::Codex.session_id/sessionId,turn_id/turnId,cwd, tool input, tool response, transcript path, and the last assistant message.apply_patchpayloads.☕️ Reasoning
Codex needs the same automatic GitButler behavior that Claude hooks already have: lock files during tool use, assign resulting hunks to the active agent session, and autocommit/reword changes when the session stops. This PR adds a native Codex hook path while keeping the existing Claude behavior intact by extracting shared agent-hook helpers.
The rewording path also needs to respect the user's configured GitButler AI provider. If Codex autocommit depends on generated commit messages and branch names, failures should be surfaced instead of silently producing weak defaults, and configured providers such as Anthropic, OpenAI, OpenRouter, Ollama, or LM Studio should be used consistently.
🧪 Testing
but codexcommand tests for:cwdwhen the process current directory is not the project,turn_idwhensession_idis absent,