perf: Improve Windows packer examples#4258
Draft
iataylor wants to merge 10 commits intogithub-aws-runners:mainfrom
Draft
perf: Improve Windows packer examples#4258iataylor wants to merge 10 commits intogithub-aws-runners:mainfrom
iataylor wants to merge 10 commits intogithub-aws-runners:mainfrom
Conversation
iataylor
commented
Nov 13, 2024
| description = "The instance type Packer will use for the builder" | ||
| type = string | ||
| default = "t3a.medium" | ||
| default = "c7i-flex.xlarge" |
Author
There was a problem hiding this comment.
I updated this to a larger instance for better build times. If we'd rather default to smaller in the example, I can replace it.
iataylor
commented
Nov 13, 2024
|
|
||
| launch_block_device_mappings { | ||
| device_name = "/dev/sda1" | ||
| volume_size = 100 |
Author
There was a problem hiding this comment.
We could leave this parameterized. I've just set this to 100 gigs hardcoded.
Author
|
All tests passed locally. |
Member
|
The CI checks for packer are failing. I will mark the PR as draft. Please feel free to mark it ready for review when you are. |
Contributor
|
The CI checks are failing on formatting, just do a packer fmt and it should then actually test the changes @iataylor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made per the issue here https://github.com/philips-labs/terraform-aws-github-runner/issues/4248.
That should be most of it.