Skip to content

[bug-fix] Harden persisted workflow run artifact access against symlinks #4930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 4 commits into
base: main
Choose a base branch
from
+602 −68
Open

[bug-fix] Harden persisted workflow run artifact access against symlinks #4930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1650af6
Fix persisted-run-symlinks: reject symlinked workflow artifacts
github-actions[bot] Oct 12, 2026
79f1da7
Fix persisted workflow snapshot symlinks
Copilot Oct 12, 2026
bd3507f
Secure workflow artifacts against run-directory swaps
Copilot Oct 12, 2026
02159bf
Support workflow persistence without dir-fd APIs
Copilot Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/specify_cli/workflows/command_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,12 @@ def workflow_status(
f"{cli._escape_markup(scope['workflow_id'])}: {scope['status']}"
)
else:
runs = engine.list_runs()
err = cli._error_console(json_output)
try:
runs = engine.list_runs()
except (OSError, ValueError) as exc:
err.print(f"[red]Error:[/red] {cli._escape_markup(str(exc))}")
Comment on lines +103 to +107

Copilot AI Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added workflow status --json regressions for symlinked run directories and state.json, asserting clean failure and stderr-only output. Fixed in 79f1da7.

Copilot AI Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow status --json listing regressions for symlinked run directories and state.json are present and pass on the current branch (02159bf0).

raise cli.typer.Exit(1)

if json_output:
payload = {
Expand Down
Loading
Loading