Skip to content

Apply upstream GitOpsSets bug fixes - #614

Merged
bigkevmcd merged 1 commit into
mainfrom
upstream-bug-fixes
Oct 30, 2026
Merged

bigkevmcd merged 1 commit into
mainfrom
upstream-bug-fixes

Conversation

@bigkevmcd

@bigkevmcd bigkevmcd commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

What changed?

This applies several changes from the weaveworks-gitopssets controler.

  • API-Client destinations can be restricted to not allow RFC1918 addresses and redirects.
  • Suspended GitOpsSets are now finalised on deletion.
  • Watch credential and header changes.
  • Pull-Request pagination
  • toYAML errors are now surfaced
  • Remove null creationTimestamp from rendered objects

Thanks to @casibbald

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps.
  • Has Tests included if any functionality added or changed.
  • Has an Example if the change requires configuration to use.
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings).
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release.

For new Generators the above notes apply, with the following additional items:

  • The Generator has been added to the Matrix generator's GitOpsSetNestedGenerator, this should be done by default unless there's some reason it doesn't work.
  • The Generator has been added to the list of configurable Generators, if you do not, the generator cannot be enabled!
  • If the Generator depends on Kubernetes resources, a Watch has been added to track changes to the resources in the controller.

Release Notes

NONE

This applies several changes from the weaveworks-gitopssets controler.

 * API-Client destinations can be restricted to not allow RFC1918
   addresses and redirects.
 * Suspended GitOpsSets are now finalised on deletion.
 * Watch credential and header changes.
 * Pull-Request pagination
 * toYAML errors are now surfaced
 * Remove null creationTimestamp from rendered objects

Co-Authored-By: Charles Sibbald <casibbald@gmail.com>
@bigkevmcd
bigkevmcd merged commit a7e061c into main Oct 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant