Repository navigation
ci: log npm's publish result in the Release workflow - #59
Conversation
release-it in --ci mode hid npm's output, so the 0.1.0 run showed only "✔ npm publish" while the version took about 5 minutes to appear on the registry. Run release-it with -VV, which logs the output of its own commands, including npm's "+ <name>@<version>" once the registry accepts the package. -V (--verbose) only logs hook output. npm's notices go to stderr, which release-it shows only when a command fails. RELEASING.md says the version can take a few minutes to show up and not to re-run the workflow or re-tag meanwhile.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Release output and publication guidance .github/workflows/release.yml, RELEASING.md |
The workflow adds -VV and updates comments about expected output. The guide explains that registry visibility may take several minutes after npm accepts the package, and instructs maintainers not to rerun the workflow or repush the tag while waiting. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related PRs
- gmi-software/react-native-pay#57: This PR modifies the release workflow and documentation introduced in
#57.
Suggested reviewers: piotr-graczyk-dev
Merge Risk: 
Minimal · up to 44da7
-
The workflow adds supported diagnostic output without changing package publication behavior.
Pre-merge checks: 
6
-
Full details: Title check
-
Explanation
The title is 52 characters, which slightly exceeds the 50-character guideline. It uses the type prefix "ci:" and describes the main change: the Release workflow now logs npm's publish result by running release-it with -VV. The title is accurate and specific, so it meets the requirement apart from the minor length overrun.
Full details: Description check
-
Explanation
The description is directly related to the changeset. It explains that the Release workflow now runs release-it with -VV so the Publish step logs npm's package version, gives the reasoning for -VV over --verbose, records the local dry-run and actionlint checks, lists the remaining unchecked rollout test, and describes the RELEASING.md note about waiting for npm to show the version.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Full details: Security Check
-
Explanation
No medium, high, or critical vulnerability is introduced. The only executable change adds release-it
-VVto the existing publish step. It logs the package/version result and release-it command output; the reviewed workflow does not pass secrets as command arguments, and the logged values are not sensitive.RELEASING.mdcontains documentation only. No prior security threads or current findings require re-reporting.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.
Comment @coderabbitai help to get the list of available commands.
Summary
-VV, so the Publish step logs npm's+ @gmisoftware/react-native-pay@<version>once the registry accepts the package. In the 0.1.0 run (40587150921)--cimode showed only✔ npm publish, and the version took about 5 minutes to appear on the registry.-VV, not--verbose: in release-it,-V/--verboseonly logs hook output, andnpm publishis one of its own commands, which only-VVlogs. npm'snpm noticelines (file list, provenance link) go to stderr, which release-it shows only when a command fails. The workflow comment says so.RELEASING.md: the version can take a few minutes to show up after the workflow finishes; don't re-run the workflow or re-push the tag meanwhile.Test plan
actionlint .github/workflows/release.yml: passespackage/package.jsontemporarily at0.1.1-verbosetest.0(reverted, not committed):GITHUB_TOKEN=$(gh auth token) bunx release-it --ci --no-increment --no-git --dry-run -VVlogs+ @gmisoftware/react-native-pay@0.1.1-verbosetest.0afternpm publish --dry-run. Without-VV(the 0.1.0 run) that line is missing.Risk
-VValso prints the output of release-it's git and npm queries (git describe,npm view), so the Publish log is longer.Notes
release.yml.Need help on this PR? Tag
@codesmith-botwith what you need.