Skip to content

perf: fast-path in validateTraceID for clean trace IDs #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankurs merged 1 commit into from
Apr 4, 2026
+13 −0
Merged

perf: fast-path in validateTraceID for clean trace IDs #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions notifier/notifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,19 @@ func validateTraceID(id string) string {
if len(id) > 128 {
id = id[:128]
}
// Fast path: most trace IDs (UUIDs, hex) are already clean.
// Scan first to avoid strings.Builder allocation.
clean := true
for i := 0; i < len(id); i++ {
if id[i] < 0x20 || id[i] > 0x7E {
clean = false
break
}
}
if clean {
return id
}
// Slow path: sanitize dirty input.
var b strings.Builder
b.Grow(len(id))
for i := 0; i < len(id); i++ {
Expand Down
Loading