Skip to content

Add Vector4 and Vector4i to TypedDictionary - #2087

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
AddisionS:fix-typed-dictionary-vector4
Nov 9, 2026
Merged

dsnopek merged 1 commit into
godotengine:masterfrom
AddisionS:fix-typed-dictionary-vector4

Conversation

@AddisionS

Copy link
Copy Markdown
Contributor

What was wrong

The header file missed template specialization for Vector4 and Vector4i in TypedDictionary.
This gives the error error C2039: 'get_class_static': is not a member of 'godot::Vector4i'.

What I changed

  • I added Vector4 and Vector4i to TypedDictionary in typed_dictionary.hpp
  • It was total 4 macro list: the value list and invocation list.
  • Placed the fix after Transform2D.

Testing

  • Reproduced the bug by adding my own dictionary call in my_test.cpp
  • Tested TypedDictionary with 3 scenarios:
    • StringName, Vector4i
    • Vector4, Vector4i
    • Vector4i, StringName
  • Used pre-commit to test my fix and passed all hooks

Fixes #1967

@AddisionS
AddisionS requested a review from a team as a code owner November 8, 2026 14:24

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me :-)

@dsnopek dsnopek added the bug This has been identified as a bug label Nov 9, 2026
@dsnopek dsnopek added this to the 10.x milestone Nov 9, 2026
@dsnopek
dsnopek merged commit 8ee1216 into godotengine:master Nov 9, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypedDictionary doesn't support Vector4(i)

2 participants