[bot] Merge master/19e1cc1d into rel/dev#1518
Merged
Merged
Conversation
- Move tests/catalog/fixtures/aac/ to tests/catalog/unit_tests/aac_tests/ so make remove-cassettes no longer deletes static AAC test data - Add VCR normalizations for traceId, authenticationId/authId, bearerToken, cacheId, queryDurationMillis, and exportResult to eliminate transient diffs - Replace counter-based hash placeholders with fixed EXECUTION_NORMALIZED and EXPORT_NORMALIZED to avoid counter drift between recording and playback - Sort XML localization groups by id for deterministic XLIFF output - Bump docker-compose: Quiver v0.398.0, Pulsar 4.1.3, Redis 8.6.1 JIRA: DX-326 risk: low
JIRA: DX-326 risk: low
Blanket replacement of all execution result hashes with the same EXECUTION_NORMALIZED constant collapsed distinct hashes into identical values, breaking tests that assert different result IDs (e.g. test_register_upload_notification). Switch to indexed placeholders (EXECUTION_NORMALIZED_1, _2, ...) so each unique hash gets a distinct canonical value while still removing environment-specific data from cassettes. risk: low
Re-recorded demo_register_upload_notification.yaml so the two execution result hashes get distinct indexed placeholders (EXECUTION_NORMALIZED_1 and EXECUTION_NORMALIZED_2), fixing replay of test_register_upload_notification. risk: low
Re-record FDW, pandas, and SDK cassettes with updated normalization. Remove AAC fixtures from cassettes directory and update related tests. risk: low
…assettes fix: move AAC fixtures out of cassettes directory
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1518 +/- ##
========================================
Coverage 78.18% 78.18%
========================================
Files 228 228
Lines 14930 14930
========================================
Hits 11673 11673
Misses 3257 3257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 19e1cc1 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/24177478818).