feat(gooddata-sdk): add dimensionality support to MetricValueFilter#1623
Merged
Conversation
Adds the optional `dimensionality` argument to `MetricValueFilter` and `CompoundMetricValueFilter`, matching the field already available on `RankingFilter`. The API client models for `ComparisonMeasureValueFilter`/`RangeMeasureValueFilter`/`CompoundMeasureValueFilter` already expose this field, so no client regeneration is required. The compute-to-SDK converter is updated to round-trip the field for all three measure value filter variants; a shared `_extract_dimensionality` helper replaces the inline cast previously used by `RankingFilter`. End-to-end verified against a local GoodData stack: with `dimensionality=[region]` the same `orders > 50` filter that returns 0 rows when applied per `(region, customer)` cell returns 884 rows when evaluated at the region-aggregation level, confirming the field is honored by the backend. JIRA: PSDK-231 risk: low
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1623 +/- ##
==========================================
+ Coverage 79.01% 79.03% +0.02%
==========================================
Files 231 231
Lines 15619 15634 +15
==========================================
+ Hits 12341 12357 +16
+ Misses 3278 3277 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mara3l
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dimensionalityargument toMetricValueFilterandCompoundMetricValueFilter, matching the field already exposed byRankingFilter.ComputeToSdkConverterto round-tripdimensionalityfor comparison / range / compound measure value filters; factor out a shared_extract_dimensionalityhelper (now also used by the existingRankingFilterbranch).ComparisonMeasureValueFilter,RangeMeasureValueFilter, andCompoundMeasureValueFilteralready exposedimensionality, so no client regeneration is required. The dashboard-layerDashboardMeasureValueFilterdoes not have this field at the API-client level, so the visualization JSON path is intentionally untouched.dimensionality=[region]the sameorders > 50filter that returns 0 rows when applied per(region, customer)cell returns 884 rows when evaluated at the region-aggregation level, confirming the field is honored by the backend.Test plan
JIRA: PSDK-231
risk: low