rules_foreign_cc: add riscv64 platform support and fix pkg-config config.guess#2376
Open
monkey-jsun wants to merge 4 commits intogoogle:mainfrom
Open
rules_foreign_cc: add riscv64 platform support and fix pkg-config config.guess#2376monkey-jsun wants to merge 4 commits intogoogle:mainfrom
monkey-jsun wants to merge 4 commits intogoogle:mainfrom
Conversation
Patch rules_rust 0.68.1 to support riscv64 as a host architecture: - Add riscv64gc to supported linux architectures in triple.bzl - Add riscv64gc-unknown-linux-gnu to SUPPORTED_PLATFORM_TRIPLES in crate_universe for generated BUILD files - Register riscv64gc Rust toolchain with Rust 1.86.0
toolchains_llvm 1.6.0 does not support riscv64 as a host architecture. Patch three files to add linux-riscv64: - toolchain/internal/common.bzl: add (linux, riscv64) to SUPPORTED_TARGETS - toolchain/internal/configure.bzl: add riscv64-unknown-linux-gnu target system name mapping - toolchain/cc_toolchain_config.bzl: add linux-riscv64 toolchain config entry mirroring linux-aarch64 Also configure llvm.MODULE.bazel to use the system-installed clang-19 at /usr/lib/llvm-19 as the toolchain root for riscv64, since no prebuilt LLVM distribution exists for riscv64 Linux host.
_is_hermetic_or_exists needs to strip the %workspace% prefix before checking path existence, so include dirs like lib64/ or arch-specific c++/v1 are filtered out when they don't exist on the host. This is a generic bug affecting any toolchain_root usage with absolute paths.
…fig.guess Add riscv64 to SUPPORTED_CPU and triplet_name in platform.bzl. Pass --build explicitly to pkg-config configure when not cross- compiling, so outdated config.guess (2015 vintage, bundled in pkg-config 0.29.2) does not need to detect the host architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add riscv64 to SUPPORTED_CPU and triplet_name in platform.bzl.
Pass --build explicitly to pkg-config configure when not cross-
compiling, so outdated config.guess (2015 vintage, bundled in
pkg-config 0.29.2) does not need to detect the host architecture.
Note this PR depends on #2365