swiftshader: add riscv64 default condition to select() blocks#2379
Open
monkey-jsun wants to merge 1 commit intogoogle:mainfrom
Open
swiftshader: add riscv64 default condition to select() blocks#2379monkey-jsun wants to merge 1 commit intogoogle:mainfrom
monkey-jsun wants to merge 1 commit intogoogle:mainfrom
Conversation
jmacnak
reviewed
Apr 10, 2026
| "third_party/llvm-16.0/llvm/lib/Target/X86/X86VZeroUpper.cpp", | ||
| "third_party/llvm-16.0/llvm/lib/Target/X86/X86WinEHState.cpp", | ||
| ], | ||
| "//conditions:default": [ |
Member
There was a problem hiding this comment.
Could you make the condition "@platforms//cpu:riscv64"? I think it's nice to be explicit so that we are forced to check and update this as new hosts are used.
Collaborator
There was a problem hiding this comment.
Alternatively, make the comment not riscv specific (with the argument that a buildbreak should happen when there is a change that must be made).
Author
There was a problem hiding this comment.
Changed to "@platforms//cpu:riscv64" per your suggestion.
The LLVM backend sources select() in BUILD.swiftshader.bazel only lists x86_64 and aarch64 entries. Currently riscv64 Bazel fails with 'no matching condition'. Add "@platforms//cpu:riscv64: []" so riscv64 falls through to pure C/software rendering without JIT backend compilation.
monkey-jsun
force-pushed
the
pr/swiftshader-riscv64
branch
from
5f6fd23 to
2223aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LLVM backend sources select() in BUILD.swiftshader.bazel only lists
x86_64 and aarch64 entries. On riscv64 Bazel fails with 'no matching
condition'. Add //conditions:default: [] so riscv64 falls through to
pure C/software rendering (SwiftShader's CPU renderer works without
arch-specific LLVM backends).