xz: add riscv64 config to disable x86 intrinsics#2382
Open
monkey-jsun wants to merge 1 commit intogoogle:mainfrom
Open
xz: add riscv64 config to disable x86 intrinsics#2382monkey-jsun wants to merge 1 commit intogoogle:mainfrom
monkey-jsun wants to merge 1 commit intogoogle:mainfrom
Conversation
xz BUILD.bazel only has config settings for x86_64 and arm64. On riscv64 it falls through to //conditions:default which uses the x86_64 config defining HAVE_IMMINTRIN_H — but immintrin.h is x86-only. Add a linux_riscv64 config_setting and expand_template that undefs x86 intrinsics, mirroring the arm64 approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xz BUILD.bazel only has config settings for x86_64 and arm64. On
riscv64 it falls through to //conditions:default which uses the x86_64
config defining HAVE_IMMINTRIN_H — but immintrin.h is x86-only.
Add a linux_riscv64 config_setting and expand_template that undefs
x86 intrinsics, mirroring the arm64 approach.