Repository navigation
Conversation
parse_swipe_parameters picked the duration with an or-chain, so an integer 0 was falsy and replaced by the 800 ms default while the string "0" survived as 0 ms. Select the first key whose value is usable as a duration instead; empty or invalid values still fall back to the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_swipe_parameterspicked the duration with anor-chain, so an integer0was falsy and got replaced by the 800 ms default, while the string"0"survived as 0 ms. The same value behaved differently by type.The fix takes the first key whose value is usable as a duration (present, not a bool, convertible to int). An explicit
0is honored; empty or invalid values still fall back to the default. The new test fails on main for the integer-zero case and passes here.This replaces #82, which I closed after the repo history was rewritten and its diff no longer applied.