Repository navigation
api: generate and verify protos with buf - #565
Open
yongruilin wants to merge 1 commit into
Open
yongruilin wants to merge 1 commit into
yongruilin wants to merge 1 commit into
Conversation
Add buf.yaml, buf.gen.yaml, and `make generate` (format, lint, generate), with the protoc plugins pinned as go.mod tools. CI regenerates and fails on any diff. Regenerated *.pb.go headers; ax.proto formatting only.
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no
make generate, and nothing checked that the checked-in*.pb.gomatch the.protofiles. This adds both.make generateformats and lints the.protofiles, then regenerates the Go code. CI (build-and-test) runs it and fails on any diff or untracked file.buf.yaml: STANDARD lint minus four rules AX deliberately differs on (commented). Breaking-change rules are commented out while the API is v1alpha1.buf.gen.yaml: protoc-gen-go and protoc-gen-go-grpc are go.modtooldirectives, and buf runs viago run, so no protoc install is needed.*.pb.gochange only in their version headers;ax.protoloses two blank lines (formatting).make generate.