Implement sharing geometry with QR code#3585
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the capability to share geometry data using QR codes, which is enabled by a foundational architectural shift towards Kotlin Multiplatform. Key domain models and UI components have been extracted into dedicated multiplatform modules, laying the groundwork for future cross-platform development while modernizing the build system and cleaning up dependencies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring to establish a multi-platform architecture by creating core/domain and core/ui modules. Shared code, including the Coordinates data class and theme files, has been moved to these new modules. A new GroundQrCode composable is also added to facilitate geometry sharing via QR codes. The changes are extensive, touching many files for import updates and build configuration, but they appear consistent and well-executed. My review focuses on the new component, where I've noted a couple of minor issues regarding the copyright year and the need for unit tests to align with the repository's style guide.
core/ui/src/commonMain/kotlin/org/groundplatform/ui/components/GroundQrCode.kt
Show resolved
Hide resolved
core/ui/src/commonMain/kotlin/org/groundplatform/ui/components/GroundQrCode.kt
Show resolved
Hide resolved
3368310 to
cab8c57
Compare
9340a0d to
d943606
Compare
74c32f4 to
a3ecfb3
Compare
…mutually exclusive states
0d06708 to
e936d28
Compare
core/domain/src/commonMain/kotlin/org/groundplatform/domain/usecases/GetLoiReportUseCase.kt
Show resolved
Hide resolved
# Conflicts: # app/src/main/res/values-es/strings.xml # app/src/main/res/values-fr/strings.xml # app/src/main/res/values-lo/strings.xml # app/src/main/res/values-pt/strings.xml # app/src/main/res/values-th/strings.xml # app/src/main/res/values-vi/strings.xml
Fixes: #3575
This PR implements a QR component shown at the end of data collection and also later on by clicking an LOI and clicking 'Share'. This component contains the LOI's geometry GeoJSON which can be scanned and read by a QR scanner.
GetLoiReportUseCaseto compute the data for LoiReport, including optimizing the generated geometry by limiting coordinates to a maximum of 6 decimalShareLocationModaland refactorDataSubmissionConfirmationScreento display the QR codeGroundQrCodewith optimizations so that a logo won't be shown if the content is too largeScreen_recording_20260403_171443.webm
@shobhitagarwal1612 PTAL?