Repository navigation
Treat leading and trailing $ in a class name as part of a top-level class name in ClassPath - #8740
Open
LubabaKhalid wants to merge 1 commit into
Open
LubabaKhalid wants to merge 1 commit into
LubabaKhalid wants to merge 1 commit into
Conversation
… class name in `ClassPath`. `ClassInfo.isTopLevel()` (and so `ClassPath.getTopLevelClasses()`) assumed that any `$` in a class name marks a nested class, so generated top-level classes like `$AutoValue_Foo` were silently dropped. `getSimpleName()` had the same problem, returning `AutoValue_Foo`. Ignore `$` characters at the start and end of the part of the name after the package when looking for the nested-class separator, as suggested in the issue discussion. This is still a heuristic, but it handles the common case of generated class names.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Author
|
@eamonnmcmanus @cpovirk could you take a look when you have a chance? This implements the leading/trailing-$ heuristic suggested in the issue discussion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassInfo.isTopLevel()(and soClassPath.getTopLevelClasses()) assumed that any$in a class name marks a nested class, so generated top-level classes like$AutoValue_Foowere silently dropped.getSimpleName()had the same problem, returningAutoValue_Foo.This ignores
$characters at the start and end of the part of the name after the package when looking for the nested-class separator, as suggested in the issue discussion. It's still a heuristic, but it handles the common case of generated class names.Added tests for
isTopLevel()andgetSimpleName().Fixes #3349