Repository navigation
Document that SimpleStatsCounter.snapshot() may be - #8745
Merged
Merged
Conversation
inconsistent with concurrent updates. `SimpleStatsCounter` is documented as thread-safe, but it updates its counters independently and without locking, so a snapshot taken during an update can include part of it (for example, a load-success count without the corresponding load time). That's intentional for performance, so document it rather than adding synchronization. Fixes #8741 RELNOTES=n/a PiperOrigin-RevId: 999541957
copybara-service
Bot
force-pushed
the
test_999520863
branch
from
October 14, 2026 19:33
bc2378f to
dea4984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that
SimpleStatsCounter.snapshot()may beinconsistent with concurrent updates.
SimpleStatsCounteris documented as thread-safe, but it updates its counters independentlyand without locking, so a snapshot taken during an update can include part of it (for example,
a load-success count without the corresponding load time). That's intentional for performance,
so document it rather than adding synchronization.
Fixes #8741
RELNOTES=n/a