Skip to content

Ignore SysctlChanged condition when using kf doctor#1106

Open
jakweg wants to merge 2 commits intomainfrom
jakweg_ignore_sysctl
Open

Ignore SysctlChanged condition when using kf doctor#1106
jakweg wants to merge 2 commits intomainfrom
jakweg_ignore_sysctl

Conversation

@jakweg
Copy link
Copy Markdown
Contributor

@jakweg jakweg commented May 6, 2026

Fixes

Current pipelines that fail for no reason, see #1105

Proposed Changes

  • Fixes kf doctor reporting status FAIL when diagnosing perfectly fine nodes by ignoring specific SysctlChanged condition.

Release Notes

`Fixed` `kf doctor` reporting FAIL on node conditions despite node being healthly

@jakweg jakweg force-pushed the jakweg_ignore_sysctl branch from 51ef29e to a3dfe3b Compare May 7, 2026 09:45
@jakweg jakweg marked this pull request as ready for review May 7, 2026 11:08
Comment thread pkg/kf/doctor/cluster.go Outdated
Copy link
Copy Markdown
Contributor

@balamut-google balamut-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my in-line comments for the node condition to be ignored

@jakweg jakweg force-pushed the jakweg_ignore_sysctl branch from 45e80a1 to 8ddad6a Compare May 7, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants