Add PSI element implementations of KSFunctionDeclarationImpl and KSPropertyDeclarationJavaImpl#2877
Open
bcorso wants to merge 1 commit intogoogle:mainfrom
Open
Add PSI element implementations of KSFunctionDeclarationImpl and KSPropertyDeclarationJavaImpl#2877bcorso wants to merge 1 commit intogoogle:mainfrom
bcorso wants to merge 1 commit intogoogle:mainfrom
Conversation
bcorso
force-pushed
the
psi-declarations
branch
from
73c6d4c to
eaedebd
Compare
jaschdoc
reviewed
Apr 22, 2026
Collaborator
jaschdoc
left a comment
jaschdoc
left a comment
There was a problem hiding this comment.
Thank you for the PR! Most of my comments are nits and most questions are just for clarification.
However, I'm concerned that we are starting to depend on the configuration mode in too many places and should reconsider how we want to support these two modes of operation. But that is outside the scope of this PR :)
bcorso
force-pushed
the
psi-declarations
branch
7 times, most recently
from
a3b1846 to
2f754ba
Compare
Collaborator
|
@bcorso, do you want me to review it again? If so, could you rebase on |
bcorso
force-pushed
the
psi-declarations
branch
2 times, most recently
from
77fe633 to
8e84ca8
Compare
bcorso
force-pushed
the
psi-declarations
branch
4 times, most recently
from
23256fd to
88035cf
Compare
jaschdoc
previously approved these changes
May 5, 2026
Collaborator
jaschdoc
left a comment
jaschdoc
left a comment
There was a problem hiding this comment.
This looks good! Thank you. My comments are mostly just nits and questions :)
bcorso
force-pushed
the
psi-declarations
branch
4 times, most recently
from
8a6132e to
a07175f
Compare
jaschdoc
previously approved these changes
May 7, 2026
Collaborator
jaschdoc
left a comment
jaschdoc
left a comment
There was a problem hiding this comment.
Looks good. I left two minor comments, we can change in another PR.
Collaborator
|
@troelsbjerre could you take a quick look as well? Thanks! |
This change adds a PSI element implementation of `KSFunctionDeclarationImpl` and `KSPropertyDeclarationJavaImpl` to work around performance bugs in the Analysis API for java source/class file declaration resolution. To use the new implementation, enable the `experimentalPsiResolution` flag. Bug: https://youtrack.jetbrains.com/issue/KT-85692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a PSI element implementation of
KSFunctionDeclarationImplandKSPropertyDeclarationJavaImplto work around performance bugs in the Analysis API for java source/class file declaration resolution (https://youtrack.jetbrains.com/issue/KT-85692).To use the new implementation, enable the
experimentalPsiResolutionflag.Bug: https://youtrack.jetbrains.com/issue/KT-85692