Conversation
jaschdoc
force-pushed
the
bugstate
branch
2 times, most recently
from
1dae7c1 to
a694858
Compare
troelsbjerre
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the
@Bugannotation with aBugState, so the reader can know if they should pay attention to the failing test. If a bug is closed / fixed then if the test fails it's a regression whereas if it's still open but then fails, the bug might just be fixed by the change.In the future, we can explore tooling to ensure the linked issue is always in the same state as the give
BugState. Lastly, it's also just a bit distracting to navigate to a GitHub issue just to see if it's still relevant.Related to #2918