Fix crash on print --all for ZenUtils patches + minor improvements#341
Open
rolbk wants to merge 4 commits intogoogle:masterfrom
Open
Fix crash on print --all for ZenUtils patches + minor improvements#341rolbk wants to merge 4 commits intogoogle:masterfrom
rolbk wants to merge 4 commits intogoogle:masterfrom
Conversation
matrizzo
reviewed
Apr 13, 2026
| "hooking" than "patching". | ||
|
|
||
| These hooks can't be placed freely in patch RAM though -- they are arranged in | ||
| fixed slots (called quads), and match register N will (almost) always redirect |
Collaborator
There was a problem hiding this comment.
Almost? When is this not the case?
Author
There was a problem hiding this comment.
Discussed offline: quad 0x56 is the entry point when --hdr-autorun=true, but it's not reachable via a match register, so the "always redirects to quad 2N" rule holds for match registers. Removed the "(almost)" and rebased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a segfault when disassembling certain ZenUtils microcode patches with
print --all. The crash happened incrypt_signed_hashbecausempz_exportreturns NULL when the operand is zero, and the result was used without a null check.Also includes:
intro.mdwith the understanding from last week's discussion--verboseflag description, since we've stumbled over its scope a few times (wording suggestions welcome)