Add scoping to conditional activation barriers. #4188
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_901835137
branch
4 times, most recently
from
b352433 to
5df6ea8
Compare
This ensures that there are not data dependencies from IO ops after the barrier, but within the scope, to IO ops before the barrier. It also enables conditional barriers to break data dependencies in general, which can help with scheduling, for example as previously only unconditional barriers could. This means that even a conditional barrier implies access to continuation values before it only through state elements. NOTE: Disabled several artifact_analyzability_tests which are misfiring. These tests are obsolete now. I will update them to use the new FSM in a follow-on. PiperOrigin-RevId: 912131659
copybara-service
Bot
force-pushed
the
test_901835137
branch
from
5df6ea8 to
53daf84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scoping to conditional activation barriers.
This ensures that there are not data dependencies from IO ops after
the barrier, but within the scope, to IO ops before the barrier.
It also enables conditional barriers to break data dependencies in general, which can help with scheduling, for example as previously only unconditional barriers could. This means that even a conditional barrier implies access to continuation values before it only through state elements.
NOTE: Disabled several artifact_analyzability_tests which are misfiring. These tests are obsolete now. I will update them to use the new FSM in a follow-on.